Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F13438347: D7887.id17866.diff
Thu, Jul 11, 8:50 PM
F13415241: D7887.diff
Sun, Jul 7, 6:47 PM
F13408401: D7887.id17866.diff
Sat, Jul 6, 4:07 AM
F13383333: D7887.id.diff
Sun, Jun 30, 11:10 AM
F13337373: D7887.diff
Wed, Jun 19, 9:30 AM
F13332540: D7887.id17846.diff
Mon, Jun 17, 2:19 PM
F13324323: D7887.diff
Fri, Jun 14, 11:35 PM
F13311555: D7887.diff
Jun 11 2024, 5:12 AM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped