Page MenuHomePhabricator

Show current config and source using arc set-config --show
ClosedPublic

Authored by iodragon on Dec 30 2013, 11:28 AM.
Tags
None
Referenced Files
F20952640: D7851.id17826.diff
Sun, Jun 28, 4:12 AM
F20952638: D7851.id17762.diff
Sun, Jun 28, 4:12 AM
F20951850: D7851.diff
Sun, Jun 28, 2:56 AM
Unknown Object (File)
Sun, Jun 7, 1:10 PM
Unknown Object (File)
Mar 13 2026, 6:00 AM
Unknown Object (File)
Feb 1 2026, 2:38 PM
Unknown Object (File)
Nov 29 2025, 10:04 AM
Unknown Object (File)
Nov 29 2025, 10:03 AM
Subscribers

Details

Summary

arc set-config --show only show the user config
It would be better to contain local/global/system config

Test Plan

set config by local/global/system/user/project, and check the result of arc set-config --show

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Some style stuff inline, I'll clean that up in the pull.

src/workflow/ArcanistSetConfigWorkflow.php
139–144

Style stuff:

  • Indent two spaces, not 4.
  • Conventionally, use head() / head_key() over reset() + each(). They have simpler semantics.
  • Avoid redundant empty() on defined variables. if (empty($x)) is always equivalent to if (!$x) for defined $x.
  • Prefer {$variable} in strings over $variable.
  • For printf() style methods, prefer %s over {$variable} in a string. For example, if we eventually introduce a source called **stars**, it will render incorrectly (with a bold style) if embedded in the string directly.