Page MenuHomePhabricator

Show current config and source using arc set-config --show
ClosedPublic

Authored by iodragon on Dec 30 2013, 11:28 AM.
Tags
None
Referenced Files
F14035706: D7851.diff
Sun, Nov 10, 7:14 AM
F14013906: D7851.id.diff
Sat, Nov 2, 7:15 PM
F14008430: D7851.id17826.diff
Tue, Oct 29, 9:16 PM
F13959043: D7851.id17762.diff
Mon, Oct 14, 5:36 PM
Unknown Object (File)
Sep 27 2024, 3:37 PM
Unknown Object (File)
Sep 23 2024, 3:38 AM
Unknown Object (File)
Sep 19 2024, 12:13 PM
Unknown Object (File)
Sep 10 2024, 9:19 AM
Subscribers

Details

Summary

arc set-config --show only show the user config
It would be better to contain local/global/system config

Test Plan

set config by local/global/system/user/project, and check the result of arc set-config --show

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Some style stuff inline, I'll clean that up in the pull.

src/workflow/ArcanistSetConfigWorkflow.php
139–144

Style stuff:

  • Indent two spaces, not 4.
  • Conventionally, use head() / head_key() over reset() + each(). They have simpler semantics.
  • Avoid redundant empty() on defined variables. if (empty($x)) is always equivalent to if (!$x) for defined $x.
  • Prefer {$variable} in strings over $variable.
  • For printf() style methods, prefer %s over {$variable} in a string. For example, if we eventually introduce a source called **stars**, it will render incorrectly (with a bold style) if embedded in the string directly.