Page MenuHomePhabricator
Differential D7871

Make resolveResources() and packageResources() private on CelerityResourceMap
ClosedPublic
Actions

Authored by epriestley on Jan 1 2014, 12:36 AM.
Tags
None
Referenced Files
F13344204: D7871.diff
Fri, Jun 21, 7:02 AM
F13329474: D7871.diff
Mon, Jun 17, 12:28 AM
F13316652: D7871.diff
Thu, Jun 13, 8:22 AM
F13314201: D7871.id.diff
Tue, Jun 11, 6:34 PM
F13307362: D7871.id.diff
Sun, Jun 9, 5:11 PM
F13307323: D7871.diff
Sun, Jun 9, 4:39 PM
F13293620: D7871.id17809.diff
Wed, Jun 5, 10:17 AM
F13290691: D7871.diff
Tue, Jun 4, 7:46 PM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
T4222: Permit Celerity to serve resources in external libphutil modules
Commits
Restricted Diffusion Commit
rP60cb65bfbb2d: Make resolveResources() and packageResources() private on CelerityResourceMap
Summary

Ref T4222. These are the last two "return a big ball of mud" methods. Make the API stronger so I can swap out the implementations.

Test Plan

Reloaded pages.

Diff Detail

Branch
celerity4d
Lint
Lint Passed
Unit
Tests Passed

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
skins/
4 lines
infrastructure/
celerity/
75 lines
2 lines
48 lines
2 lines

Diff 17800

View Options

src/applications/phame/skins/PhameBasicTemplateBlogSkin.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceMap.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceTransformer.php

Loading...
View Options

src/infrastructure/celerity/CelerityStaticResourceResponse.php

Loading...
View Options

src/infrastructure/celerity/api.php

Loading...
Phabricator · Built by Phacility