Page MenuHomePhabricator
Differential D7871

Make resolveResources() and packageResources() private on CelerityResourceMap
ClosedPublic
Actions

Authored by epriestley on Jan 1 2014, 12:36 AM.
Tags
None
Referenced Files
F14080074: D7871.diff
Fri, Nov 22, 11:24 AM
F14076839: D7871.diff
Thu, Nov 21, 7:53 PM
F14076350: D7871.diff
Thu, Nov 21, 4:57 PM
Unknown Object (File)
Thu, Nov 21, 8:08 AM
Unknown Object (File)
Mon, Nov 18, 1:03 AM
Unknown Object (File)
Wed, Nov 13, 4:35 PM
Unknown Object (File)
Sun, Nov 10, 4:14 AM
Unknown Object (File)
Tue, Nov 5, 6:54 PM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
T4222: Permit Celerity to serve resources in external libphutil modules
Commits
Restricted Diffusion Commit
rP60cb65bfbb2d: Make resolveResources() and packageResources() private on CelerityResourceMap
Summary

Ref T4222. These are the last two "return a big ball of mud" methods. Make the API stronger so I can swap out the implementations.

Test Plan

Reloaded pages.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Revision Contents
Changeset List

PathSize
src/
applications/
phame/
skins/
4 lines
infrastructure/
celerity/
75 lines
2 lines
48 lines
2 lines

Diff 17809

View Options

src/applications/phame/skins/PhameBasicTemplateBlogSkin.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceMap.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceTransformer.php

Loading...
View Options

src/infrastructure/celerity/CelerityStaticResourceResponse.php

Loading...
View Options

src/infrastructure/celerity/api.php

Loading...
Phabricator · Built by Phacility