Show current config and source using arc set-config --show
ClosedPublic
Actions

Authored by iodragon on Dec 30 2013, 11:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 24, 10:36 PM

	Unknown Object (File)
	Fri, Jan 24, 10:41 AM

	Unknown Object (File)
	Fri, Jan 24, 6:33 AM

	Unknown Object (File)
	Sun, Jan 19, 11:42 AM

	Unknown Object (File)
	Thu, Jan 9, 10:16 PM

	Unknown Object (File)
	Sat, Dec 28, 3:09 PM

	Unknown Object (File)
	Dec 22 2024, 1:27 PM

	Unknown Object (File)
	Dec 20 2024, 4:55 PM

View All Files

Subscribers

aran

epriestley

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC6769c6b17ca5: Show current config and source using arc set-config --show

Summary

arc set-config --show only show the user config
It would be better to contain local/global/system config

Test Plan

set config by local/global/system/user/project, and check the result of arc set-config --show

Diff Detail

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Some style stuff inline, I'll clean that up in the pull.

src/workflow/ArcanistSetConfigWorkflow.php
139–146	Style stuff: Indent two spaces, not 4. Conventionally, use `head()` / `head_key()` over `reset()` + `each()`. They have simpler semantics. Avoid redundant `empty()` on defined variables. `if (empty($x))` is always equivalent to `if (!$x)` for defined `$x`. Prefer `{$variable}` in strings over `$variable`. For printf() style methods, prefer `%s` over `{$variable}` in a string. For example, if we eventually introduce a source called `stars`, it will render incorrectly (with a bold style) if embedded in the string directly.

Closed by commit rARC6769c6b17ca5 (authored by @iodragon, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistSetConfigWorkflow.php

16 lines

Diff 17762

View Options

src/workflow/ArcanistSetConfigWorkflow.php

Show current config and source using arc set-config --showClosedPublicActions