Page MenuHomePhabricator
Differential D7813

Herald - add support for "assignee" conditions
ClosedPublic
Actions

Authored by xiaogaozi on Dec 21 2013, 3:01 AM.
Tags
None
Referenced Files
F19827748: D7813.id.diff
Mon, Mar 9, 12:20 PM
F19801710: D7813.diff
Sun, Mar 1, 6:02 AM
F19749574: D7813.id.diff
Sun, Feb 15, 8:24 PM
F19559562: D7813.id17680.diff
Jan 31 2026, 1:47 AM
F18877738: D7813.id.diff
Nov 6 2025, 11:45 AM
F18873932: D7813.diff
Nov 5 2025, 12:14 PM
F18836332: D7813.diff
Oct 27 2025, 12:02 AM
F18780504: D7813.diff
Oct 12 2025, 4:41 PM
View All Files
Subscribers
aran
epriestley
Korvin
Tokens
"Piece of Eight" token, awarded by Leenug.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP54a0dd813908: Herald - add support for "assignee" conditions
Summary

add support for "assignee" conditions

Test Plan

Create a Herald rule where condition is assignee, and create a task assign to someone.

Diff Detail

Branch
herald-assignee
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley accepted this revision.Dec 22 2013, 4:47 PM

Thanks! I'm going to make one minor change in the pull (see inline) to make this slightly more flexible.

src/applications/herald/adapter/HeraldAdapter.php
235

I think this field should use this set of conditions instead, because a task may not be assigned, so "Assignee does not exist" is a meaningful filter for finding unowned tasks.

epriestley closed this revision.Dec 22 2013, 4:48 PM

Closed by commit rP54a0dd813908 (authored by @xiaogaozi, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
3 lines
3 lines
storage/
2 lines

Diff 17680

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility