Page MenuHomePhabricator
Differential D7813

Herald - add support for "assignee" conditions
ClosedPublic
Actions

Authored by xiaogaozi on Dec 21 2013, 3:01 AM.
Tags
None
Referenced Files
F13202852: D7813.diff
Tue, May 14, 11:11 PM
F13201605: D7813.diff
Tue, May 14, 1:32 PM
F13187227: D7813.diff
Sat, May 11, 4:24 AM
F13175302: D7813.diff
Wed, May 8, 4:32 AM
Unknown Object (File)
Tue, May 7, 6:16 AM
Unknown Object (File)
Fri, May 3, 5:33 AM
Unknown Object (File)
Wed, May 1, 5:09 PM
Unknown Object (File)
Mon, Apr 29, 4:22 PM
View All Files
Subscribers
aran
epriestley
Korvin
Tokens
"Piece of Eight" token, awarded by Leenug.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP54a0dd813908: Herald - add support for "assignee" conditions
Summary

add support for "assignee" conditions

Test Plan

Create a Herald rule where condition is assignee, and create a task assign to someone.

Diff Detail

Branch
herald-assignee
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley accepted this revision.Dec 22 2013, 4:47 PM

Thanks! I'm going to make one minor change in the pull (see inline) to make this slightly more flexible.

src/applications/herald/adapter/HeraldAdapter.php
235

I think this field should use this set of conditions instead, because a task may not be assigned, so "Assignee does not exist" is a meaningful filter for finding unowned tasks.

epriestley closed this revision.Dec 22 2013, 4:48 PM

Closed by commit rP54a0dd813908 (authored by @xiaogaozi, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
3 lines
3 lines
storage/
2 lines

Diff 17680

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility