Page MenuHomePhabricator

Herald - add support for "assignee" conditions
ClosedPublic

Authored by xiaogaozi on Dec 21 2013, 3:01 AM.
Tags
None
Referenced Files
F12844278: D7813.id17680.diff
Thu, Mar 28, 11:25 PM
Unknown Object (File)
Feb 14 2024, 9:41 AM
Unknown Object (File)
Feb 8 2024, 7:18 PM
Unknown Object (File)
Feb 7 2024, 3:28 PM
Unknown Object (File)
Feb 7 2024, 3:28 PM
Unknown Object (File)
Feb 7 2024, 3:16 PM
Unknown Object (File)
Feb 4 2024, 2:45 AM
Unknown Object (File)
Jan 22 2024, 7:44 PM
Tokens
"Piece of Eight" token, awarded by Leenug.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP54a0dd813908: Herald - add support for "assignee" conditions
Summary

add support for "assignee" conditions

Test Plan

Create a Herald rule where condition is assignee, and create a task assign to someone.

Diff Detail

Branch
herald-assignee
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Thanks! I'm going to make one minor change in the pull (see inline) to make this slightly more flexible.

src/applications/herald/adapter/HeraldAdapter.php
235

I think this field should use this set of conditions instead, because a task may not be assigned, so "Assignee does not exist" is a meaningful filter for finding unowned tasks.