Page MenuHomePhabricator

Add "is merge commit" Herald field for pre-commit rules
ClosedPublic

Authored by epriestley on Dec 20 2013, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 3, 4:11 AM
Unknown Object (File)
Mon, Dec 30, 12:40 PM
Unknown Object (File)
Mon, Dec 30, 11:47 AM
Unknown Object (File)
Mon, Dec 30, 5:39 AM
Unknown Object (File)
Fri, Dec 27, 10:42 PM
Unknown Object (File)
Wed, Dec 25, 8:27 PM
Unknown Object (File)
Fri, Dec 20, 8:32 PM
Unknown Object (File)
Thu, Dec 19, 12:38 AM
Subscribers

Details

Summary

Ref T4195. This allows you to write rules which disallow merge commits.

Also make the reject message a little more useful.

Test Plan
remote: This push was rejected by Herald push rule H27.
remote: Change: commit/daed0d448404
remote:   Rule: No Merges
remote: Reason: No merge commits allowed. If you must push a merge, include "@force-merge" in the commit message.

Diff Detail

Branch
hashq6
Lint
Lint Passed
Unit
No Test Coverage