Page MenuHomePhabricator
Differential D7809

Add "is merge commit" Herald field for pre-commit rules
ClosedPublic
Actions

Authored by epriestley on Dec 20 2013, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 10:42 PM
Unknown Object (File)
Wed, Dec 25, 8:27 PM
Unknown Object (File)
Fri, Dec 20, 8:32 PM
Unknown Object (File)
Thu, Dec 19, 12:38 AM
Unknown Object (File)
Mon, Dec 9, 6:32 AM
Unknown Object (File)
Mon, Dec 2, 11:09 AM
Unknown Object (File)
Sat, Nov 30, 7:30 AM
Unknown Object (File)
Sat, Nov 30, 7:30 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rPa64d127e2569: Add "is merge commit" Herald field for pre-commit rules
Summary

Ref T4195. This allows you to write rules which disallow merge commits.

Also make the reject message a little more useful.

Test Plan
remote: This push was rejected by Herald push rule H27.
remote: Change: commit/daed0d448404
remote:   Rule: No Merges
remote: Reason: No merge commits allowed. If you must push a merge, include "@force-merge" in the commit message.

Diff Detail

Branch
hashq6
Lint
Lint Passed
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
13 lines
herald/
23 lines
herald/
adapter/
17 lines

Diff 17666

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility