Page MenuHomePhabricator
Differential D7796

Implement "Body" field in Herald pre-commit contnet hooks
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 11:09 PM.
Tags
None
Referenced Files
F14501300: D7796.id17636.diff
Sat, Jan 4, 1:06 PM
F14501284: D7796.id17637.diff
Sat, Jan 4, 12:51 PM
Unknown Object (File)
Fri, Dec 27, 4:50 PM
Unknown Object (File)
Tue, Dec 24, 4:55 PM
Unknown Object (File)
Sat, Dec 14, 3:49 PM
Unknown Object (File)
Fri, Dec 13, 10:04 PM
Unknown Object (File)
Thu, Dec 12, 9:36 AM
Unknown Object (File)
Mon, Dec 9, 11:41 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP151f01ae9477: Implement "Body" field in Herald pre-commit content hooks
Summary

Ref T4195. Adds support for writing rules against commit message bodies.

Test Plan

Pushed git, hg, svn commits and verified their bodies populated correctly in transcripts.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 18 2013, 11:18 PM
  • Spell "content" correctly.
btrahan accepted this revision.Dec 19 2013, 12:11 AM
epriestley closed this revision.Dec 19 2013, 2:56 PM

Closed by commit rP151f01ae9477 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
30 lines
herald/
11 lines
herald/
storage/
2 lines

Diff 17648

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility