Page MenuHomePhabricator
Differential D7796

Implement "Body" field in Herald pre-commit contnet hooks
ClosedPublic
Actions

Authored by epriestley on Dec 18 2013, 11:09 PM.
Tags
None
Referenced Files
F15519896: D7796.id17648.diff
Sun, Apr 20, 12:44 AM
F15513595: D7796.id.diff
Thu, Apr 17, 8:06 PM
F15509390: D7796.diff
Wed, Apr 16, 12:03 PM
F15508292: D7796.diff
Wed, Apr 16, 4:14 AM
F15422392: D7796.id.diff
Mar 22 2025, 7:55 AM
F15404547: D7796.diff
Mar 18 2025, 8:13 AM
F15403261: D7796.id17637.diff
Mar 18 2025, 2:29 AM
F15397778: D7796.id17636.diff
Mar 16 2025, 10:15 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T4195: Implement pre-commit Herald rules
Commits
Restricted Diffusion Commit
rP151f01ae9477: Implement "Body" field in Herald pre-commit content hooks
Summary

Ref T4195. Adds support for writing rules against commit message bodies.

Test Plan

Pushed git, hg, svn commits and verified their bodies populated correctly in transcripts.

Diff Detail

Branch
hbody3
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Dec 18 2013, 11:18 PM
  • Spell "content" correctly.
btrahan accepted this revision.Dec 19 2013, 12:11 AM
epriestley closed this revision.Dec 19 2013, 2:56 PM

Closed by commit rP151f01ae9477 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
30 lines
herald/
11 lines
herald/
storage/
2 lines

Diff 17637

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/herald/HeraldPreCommitContentAdapter.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility