Depends on D7727. This adds support for downloading a fragment and all it's children as a ZIP file. Fragments that have children automatically become directories in the ZIP file.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4205: Implement Phragment
- Commits
- Restricted Diffusion Commit
rPccd4ae563827: Implement "Download ZIP" controller for Phragment
Downloaded a fragment as a ZIP and was able to extract the contents successfully.
Diff Detail
Diff Detail
- Branch
- phragment-zip-download
- Lint
Lint Passed Severity Location Code Message Advice src/applications/phragment/controller/PhragmentController.php:97 XHP16 TODO Comment - Unit
No Test Coverage
Event Timeline
| src/applications/phragment/controller/PhragmentZIPController.php | ||
|---|---|---|
| 80 | Probably shouldn't have the cache set to one month? | |
| src/applications/phragment/controller/PhragmentZIPController.php | ||
|---|---|---|
| 35–37 | Recently, there's a slightly more convenient appendParagraph(). | |
| 76–82 | Although this is probably safe, it's better to write it into Files and then redirect. Files refcounts actual content blobs already, so multiple calls won't write the data multiple times. This puts us a step closer to caching this, too. You can look at DiffusionBrowseFileController->loadFileForData() for the cliffnotes version of this. | |