Page MenuHomePhabricator

Improve performacne of PhutilSymbolLoader
ClosedPublic

Authored by epriestley on Nov 14 2013, 12:26 AM.
Tags
None
Referenced Files
F15427235: D7584.id.diff
Sun, Mar 23, 1:24 PM
F15407461: D7584.id.diff
Tue, Mar 18, 5:36 PM
F15402385: D7584.diff
Mon, Mar 17, 10:15 PM
F15397770: D7584.id17122.diff
Sun, Mar 16, 10:12 PM
F15389554: D7584.id17122.diff
Sat, Mar 15, 5:25 AM
F15387451: D7584.id17120.diff
Sat, Mar 15, 2:25 AM
F15337563: D7584.id17120.diff
Sun, Mar 9, 6:29 AM
Unknown Object (File)
Feb 24 2025, 3:03 AM
Subscribers
Tokens
"Love" token, awarded by nmalcolm.

Details

Summary

Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan

650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Diff Detail

Branch
sperf
Lint
Lint Passed
Unit
No Test Coverage