Page MenuHomePhabricator

Improve performacne of PhutilSymbolLoader
ClosedPublic

Authored by epriestley on Nov 14 2013, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 1:43 PM
Unknown Object (File)
Fri, Dec 13, 4:03 PM
Unknown Object (File)
Fri, Dec 6, 7:05 PM
Unknown Object (File)
Nov 29 2024, 1:09 AM
Unknown Object (File)
Nov 27 2024, 1:22 PM
Unknown Object (File)
Nov 18 2024, 7:58 PM
Unknown Object (File)
Nov 6 2024, 6:12 AM
Unknown Object (File)
Oct 30 2024, 2:21 PM
Subscribers
Tokens
"Love" token, awarded by nmalcolm.

Details

Summary

Currently, we build way more symbols than we need to when doing loadObjects(). Instead, select only the candidates we know will match the request.

Test Plan

650ms -> 380ms on Differential revision page, which hits this more than it probably should.

Diff Detail

Branch
sperf
Lint
Lint Passed
Unit
No Test Coverage