Page MenuHomePhabricator

Put back the stronger variable replacement
ClosedPublic

Authored by hach-que on Nov 9 2013, 2:34 AM.
Tags
None
Referenced Files
F17830395: D7539.diff
Sat, Jul 26, 11:02 AM
Unknown Object (File)
Sat, Jul 5, 1:16 PM
Unknown Object (File)
Sat, Jun 28, 4:47 PM
Unknown Object (File)
Fri, Jun 27, 10:57 AM
Unknown Object (File)
Jun 4 2025, 7:10 PM
Unknown Object (File)
Jun 1 2025, 4:20 AM
Unknown Object (File)
May 31 2025, 4:05 PM
Unknown Object (File)
May 28 2025, 4:01 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rP197e9b6f49aa: Put back the stronger variable replacement
Summary

This puts back the stronger variable replacement that was missed the last update to D7519.

Test Plan

Re-ran a remote build that had variables in the command and everything worked as expected.

Diff Detail

Branch
stronger-variables
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php:233PHL1Unknown Symbol
Warningsrc/applications/harbormaster/step/RemoteCommandBuildStepImplementation.php:43PHLXHP4Unsafe Usage of Dynamic String
Unit
No Test Coverage