Page MenuHomePhabricator

Put back the stronger variable replacement
ClosedPublic

Authored by hach-que on Nov 9 2013, 2:34 AM.
Tags
None
Referenced Files
F14034520: D7539.diff
Sun, Nov 10, 12:47 AM
F14030301: D7539.id17013.diff
Sat, Nov 9, 2:04 AM
F14020912: D7539.diff
Wed, Nov 6, 3:42 AM
F14001795: D7539.id.diff
Fri, Oct 25, 12:02 PM
F13998849: D7539.id17013.diff
Thu, Oct 24, 11:30 AM
F13995487: D7539.diff
Wed, Oct 23, 1:16 PM
F13976693: D7539.id17012.diff
Fri, Oct 18, 3:19 PM
F13972003: D7539.id17013.diff
Thu, Oct 17, 4:38 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T1049: Implement Harbormaster
Commits
Restricted Diffusion Commit
rP197e9b6f49aa: Put back the stronger variable replacement
Summary

This puts back the stronger variable replacement that was missed the last update to D7519.

Test Plan

Re-ran a remote build that had variables in the command and everything worked as expected.

Diff Detail

Branch
stronger-variables
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php:233PHL1Unknown Symbol
Warningsrc/applications/harbormaster/step/RemoteCommandBuildStepImplementation.php:43PHLXHP4Unsafe Usage of Dynamic String
Unit
No Test Coverage