Fix weird issue where INF is not respected in PHP 5.5
ClosedPublic
Actions

Authored by skyronic on Nov 8 2013, 2:49 PM.

Tags

None

Referenced Files

	F13812956: D7530.id16985.diff
	Wed, Sep 18, 7:15 PM

	F13812923: D7530.id16987.diff
	Wed, Sep 18, 7:01 PM

	Unknown Object (File)
	Sun, Sep 15, 6:12 PM

	Unknown Object (File)
	Sun, Sep 15, 5:57 PM

	Unknown Object (File)
	Sun, Sep 15, 5:36 AM

	Unknown Object (File)
	Sun, Sep 15, 1:24 AM

	Unknown Object (File)
	Fri, Sep 6, 8:12 PM

	Unknown Object (File)
	Wed, Sep 4, 10:04 AM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1bcf478c698e: Fix weird issue where INF is not respected in PHP 5.5

Summary

After upgrading to PHP 5.5, the conduit list was not fully visible because
INF was being treated as "0" for some reason. Fixed by making it a PHP_MAX_INT

Test Plan

Checked on PHP 5.5

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Closed by commit rP1bcf478c698e (authored by @skyronic, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

query/

PhabricatorConduitSearchEngine.php

2 lines

Diff 16987

View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Fix weird issue where INF is not respected in PHP 5.5ClosedPublicActions