Fix weird issue where INF is not respected in PHP 5.5
ClosedPublic
Actions

Authored by skyronic on Nov 8 2013, 2:49 PM.

Tags

None

Referenced Files

	F14634964: D7530.diff
	Fri, Jan 10, 9:51 PM

	Unknown Object (File)
	Sat, Dec 21, 10:39 PM

	Unknown Object (File)
	Tue, Dec 17, 8:15 AM

	Unknown Object (File)
	Mon, Dec 16, 10:34 AM

	Unknown Object (File)
	Dec 10 2024, 7:14 PM

	Unknown Object (File)
	Dec 9 2024, 12:50 PM

	Unknown Object (File)
	Dec 6 2024, 6:10 AM

	Unknown Object (File)
	Dec 5 2024, 1:34 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1bcf478c698e: Fix weird issue where INF is not respected in PHP 5.5

Summary

After upgrading to PHP 5.5, the conduit list was not fully visible because
INF was being treated as "0" for some reason. Fixed by making it a PHP_MAX_INT

Test Plan

Checked on PHP 5.5

Diff Detail

Branch

conduit_countfix

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

Closed by commit rP1bcf478c698e (authored by @skyronic, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

query/

PhabricatorConduitSearchEngine.php

2 lines

Diff 16985

View Options

src/applications/conduit/query/PhabricatorConduitSearchEngine.php

Fix weird issue where INF is not respected in PHP 5.5ClosedPublicActions