Allow Herald's "Reviewers" field to select project reviewers
ClosedPublic
Actions

Authored by epriestley on Nov 7 2013, 7:03 PM.

Tags

None

Referenced Files

	F17837774: D7526.id16972.diff
	Sat, Jul 26, 5:48 PM

	F17829005: D7526.id16971.diff
	Sat, Jul 26, 9:42 AM

	F17828329: D7526.diff
	Sat, Jul 26, 9:05 AM

	Unknown Object (File)
	Jun 16 2025, 8:37 AM

	Unknown Object (File)
	Jun 16 2025, 3:49 AM

	Unknown Object (File)
	Jun 15 2025, 8:41 AM

	Unknown Object (File)
	May 25 2025, 4:35 PM

	Unknown Object (File)
	Apr 15 2025, 11:22 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP038f5323c017: Allow Herald's "Reviewers" field to select project reviewers

Summary

The "Reviewers" condition in Differential Revision rules has the wrong typeahead and can't select projects, but should be able to.

Test Plan

{F79273}

Diff Detail

Branch

reviewerrule

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Nov 7 2013, 7:23 PM

Closed by commit rP038f5323c017 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 16971

View Options

src/applications/herald/adapter/HeraldAdapter.php

Allow Herald's "Reviewers" field to select project reviewersClosedPublicActions