Allow Herald's "Reviewers" field to select project reviewers
ClosedPublic
Actions

Authored by epriestley on Nov 7 2013, 7:03 PM.

Tags

None

Referenced Files

	F13993725: D7526.id16971.diff
	Wed, Oct 23, 1:00 AM

	F13989028: D7526.id16972.diff
	Mon, Oct 21, 5:34 PM

	F13986230: D7526.diff
	Mon, Oct 21, 1:29 AM

	F13986216: D7526.id.diff
	Mon, Oct 21, 1:24 AM

	F13986212: D7526.id16971.diff
	Mon, Oct 21, 1:23 AM

	F13986208: D7526.id16972.diff
	Mon, Oct 21, 1:21 AM

	F13982465: D7526.diff
	Sat, Oct 19, 11:30 PM

	F13982462: D7526.diff
	Sat, Oct 19, 11:29 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP038f5323c017: Allow Herald's "Reviewers" field to select project reviewers

Summary

The "Reviewers" condition in Differential Revision rules has the wrong typeahead and can't select projects, but should be able to.

Test Plan

{F79273}

Diff Detail

Branch

reviewerrule

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Nov 7 2013, 7:23 PM

Closed by commit rP038f5323c017 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

2 lines

Diff 16971

View Options

src/applications/herald/adapter/HeraldAdapter.php

Allow Herald's "Reviewers" field to select project reviewersClosedPublicActions