Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
F15447395: D7507.id16931.diff
Thu, Mar 27, 11:33 PM
Unknown Object (File)
Feb 26 2025, 4:59 AM
Unknown Object (File)
Feb 24 2025, 3:01 AM
Unknown Object (File)
Feb 17 2025, 8:58 AM
Unknown Object (File)
Feb 15 2025, 10:48 PM
Unknown Object (File)
Feb 4 2025, 3:08 PM
Unknown Object (File)
Jan 31 2025, 4:24 AM
Unknown Object (File)
Jan 25 2025, 11:11 AM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.