Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
F18578009: D7507.diff
Wed, Sep 10, 8:30 PM
F17638305: D7507.id16931.diff
Jul 11 2025, 4:30 PM
F17638304: D7507.id16928.diff
Jul 11 2025, 4:30 PM
Unknown Object (File)
Jun 29 2025, 3:23 AM
Unknown Object (File)
May 28 2025, 7:05 PM
Unknown Object (File)
May 26 2025, 10:08 PM
Unknown Object (File)
May 26 2025, 3:22 PM
Unknown Object (File)
May 26 2025, 6:23 AM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.