Paths

Table of Contentst

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic
Actions

Authored by epriestley on Nov 5 2013, 11:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:13 AM

	Unknown Object (File)
	Wed, Nov 20, 6:24 PM

	Unknown Object (File)
	Sat, Nov 16, 7:37 AM

	Unknown Object (File)
	Thu, Nov 14, 5:44 AM

	Unknown Object (File)
	Thu, Nov 14, 5:19 AM

	Unknown Object (File)
	Thu, Nov 14, 3:22 AM

	Unknown Object (File)
	Wed, Nov 13, 3:24 AM

	Unknown Object (File)
	Mon, Nov 11, 10:18 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4064: Empty password not handled correctly for Git clone

Commits

Restricted Diffusion Commit
rPd5f41ef70ed0: Return HTTP 500, not HTTP 200, on exception pages

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Seems good, but I'll leave @btrahan to verify.

btrahan accepted this revision.Nov 5 2013, 11:20 PM

Closed by commit rPd5f41ef70ed0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

aphront/

configuration/

AphrontDefaultApplicationConfiguration.php

2 lines

applications/

base/

controller/

PhabricatorController.php

7 lines

Diff 16931

View Options

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php