Don't throw when user tries to use an empty password via HTTP auth
ClosedPublic
Actions

Authored by epriestley on Nov 5 2013, 11:15 PM.

Tags

None

Referenced Files

	F14036973: D7508.id16930.diff
	Sun, Nov 10, 1:12 PM

	F13994551: D7508.id.diff
	Wed, Oct 23, 6:58 AM

	F13991499: D7508.id16930.diff
	Tue, Oct 22, 11:16 AM

	F13976391: D7508.diff
	Fri, Oct 18, 2:03 PM

	F13971039: D7508.id16929.diff
	Thu, Oct 17, 11:10 AM

	F13962029: D7508.diff
	Tue, Oct 15, 7:39 AM

	Unknown Object (File)
	Sep 20 2024, 1:24 PM

	Unknown Object (File)
	Sep 20 2024, 11:47 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4064: Empty password not handled correctly for Git clone

Commits

Restricted Diffusion Commit
rPce48375951bd: Don't throw when user tries to use an empty password via HTTP auth

Summary

Fixes T4064. See discussion there.

Test Plan

Tried git clone http://... with empty password, got 403. Retried with actual password, got a clone.

Diff Detail

Branch

ghost

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

btrahan accepted this revision.Nov 5 2013, 11:21 PM

Closed by commit rPce48375951bd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

14 lines

Diff 16929

View Options

src/applications/diffusion/controller/DiffusionController.php

Don't throw when user tries to use an empty password via HTTP authClosedPublicActions