Don't throw when user tries to use an empty password via HTTP auth
ClosedPublic
Actions

Authored by epriestley on Nov 5 2013, 11:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 12, 3:32 AM

	Unknown Object (File)
	Fri, Sep 6, 5:02 AM

	Unknown Object (File)
	Tue, Sep 3, 11:24 PM

	Unknown Object (File)
	Sun, Sep 1, 11:25 PM

	Unknown Object (File)
	Fri, Aug 30, 11:38 PM

	Unknown Object (File)
	Sun, Aug 25, 4:00 PM

	Unknown Object (File)
	Sun, Aug 25, 3:59 AM

	Unknown Object (File)
	Aug 19 2024, 2:45 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4064: Empty password not handled correctly for Git clone

Commits

Restricted Diffusion Commit
rPce48375951bd: Don't throw when user tries to use an empty password via HTTP auth

Summary

Fixes T4064. See discussion there.

Test Plan

Tried git clone http://... with empty password, got 403. Retried with actual password, got a clone.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 5 2013, 11:21 PM

Closed by commit rPce48375951bd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

14 lines

Diff 16930

View Options

src/applications/diffusion/controller/DiffusionController.php

Don't throw when user tries to use an empty password via HTTP authClosedPublicActions