Page MenuHomePhabricator

Survive pull/discover for hosted repositories in all VCSes
ClosedPublic

Authored by epriestley on Nov 1 2013, 10:07 PM.
Tags
None
Referenced Files
F13819339: D7474.id16851.diff
Fri, Sep 20, 1:29 PM
F13819336: D7474.id16846.diff
Fri, Sep 20, 1:29 PM
Unknown Object (File)
Thu, Sep 5, 7:09 PM
Unknown Object (File)
Wed, Sep 4, 3:17 PM
Unknown Object (File)
Tue, Aug 27, 11:32 PM
Unknown Object (File)
Sun, Aug 25, 5:40 AM
Unknown Object (File)
Sun, Aug 25, 4:49 AM
Unknown Object (File)
Fri, Aug 23, 1:03 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP3607bd487cc0: Survive pull/discover for hosted repositories in all VCSes
Summary

Hosted repositories only sometimes survive the pull/discover phases right now, due to issues like:

  • Pull tries to git clone, but should git init.
  • Mercurial doesn't handle empty repositories with on branches.
  • SVN tries to connect to an invalid remote.
  • None of them set the INIT repo flag correctly, so status doesn't get updated properly in the UI.

Fix all this stuff.

Test Plan
  • For each of Git, SVN and Mercurial:
    • Created a new repository from the web UI in a deactivated state.
    • Made it hosted.
    • Manually ran pull/discover.
    • Verified we end up with initialized, empty repositories in consistent states.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

with on branches

with "no" branches

epriestley updated this revision to Unknown Object (????).Nov 1 2013, 10:15 PM
  • "workin" -> "working"
btrahan added inline comments.
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
29

false

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
29

haha thanks

Macro bythepowerof: By the power of CODE REVIEW