Page MenuHomePhabricator
Differential D7474

Survive pull/discover for hosted repositories in all VCSes
ClosedPublic
Actions

Authored by epriestley on Nov 1 2013, 10:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 2:55 PM
Unknown Object (File)
Wed, Dec 11, 3:35 PM
Unknown Object (File)
Mon, Dec 9, 9:56 PM
Unknown Object (File)
Fri, Dec 6, 7:10 AM
Unknown Object (File)
Wed, Dec 4, 12:30 PM
Unknown Object (File)
Wed, Dec 4, 12:29 PM
Unknown Object (File)
Wed, Dec 4, 12:29 PM
Unknown Object (File)
Wed, Dec 4, 12:29 PM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP3607bd487cc0: Survive pull/discover for hosted repositories in all VCSes
Summary

Hosted repositories only sometimes survive the pull/discover phases right now, due to issues like:

  • Pull tries to git clone, but should git init.
  • Mercurial doesn't handle empty repositories with on branches.
  • SVN tries to connect to an invalid remote.
  • None of them set the INIT repo flag correctly, so status doesn't get updated properly in the UI.

Fix all this stuff.

Test Plan
  • For each of Git, SVN and Mercurial:
    • Created a new repository from the web UI in a deactivated state.
    • Made it hosted.
    • Manually ran pull/discover.
    • Verified we end up with initialized, empty repositories in consistent states.

Diff Detail

Branch
pullhost
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley added a comment.Nov 1 2013, 10:14 PM

with on branches

with "no" branches

epriestley updated this revision to Unknown Object (????).Nov 1 2013, 10:15 PM
  • "workin" -> "working"
btrahan accepted this revision.Nov 1 2013, 11:17 PM
btrahan added inline comments.
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
29

false

epriestley added inline comments.Nov 1 2013, 11:33 PM
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
29

haha thanks

Macro bythepowerof: By the power of CODE REVIEW

epriestley closed this revision.Nov 2 2013, 12:37 AM

Closed by commit rP3607bd487cc0 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
daemon/
29 lines
engine/
106 lines
storage/
32 lines

Diff 16846

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility