Page MenuHomePhabricator

Fix various branch/ref issues with bare repositories in Git
ClosedPublic

Authored by epriestley on Oct 30 2013, 3:39 AM.
Tags
None
Referenced Files
F14043301: D7442.diff
Tue, Nov 12, 9:08 AM
F14025420: D7442.diff
Thu, Nov 7, 5:43 PM
F14001246: D7442.id16769.diff
Fri, Oct 25, 5:32 AM
F13987698: D7442.diff
Mon, Oct 21, 10:49 AM
F13979623: D7442.id.diff
Sat, Oct 19, 5:32 AM
F13968003: D7442.id.diff
Wed, Oct 16, 5:49 PM
Unknown Object (File)
Oct 13 2024, 6:25 PM
Unknown Object (File)
Oct 11 2024, 3:58 PM
Subscribers

Details

Reviewers
btrahan
avivey
avive
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP19124554d8b9: Fix various branch/ref issues with bare repositories in Git
Summary

Ref T2230. Although all the non-bare commands run fine in bare repos, not all of them do exactly the same thing.

This could use further cleanup, but at least get it working again for now.

Test Plan

Ran bin/repository pull, bin/repository discover, viewed Diffusion (looked at branch table), viewed a commit (looked at "Branches"), for bare and non-bare git repos.

Diff Detail

Branch
branchr
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Looks ok to me...

src/applications/repository/storage/PhabricatorRepository.php
793

maybe isWorkingCopyBare()?

epriestley updated this revision to Unknown Object (????).Oct 30 2013, 4:04 AM
  • hasBareWorkingCopy() -> isWorkingCopyBare()