Page MenuHomePhabricator

Serve Git reads over SSH
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:22 PM.
Tags
None
Referenced Files
F14027899: D7424.id16717.diff
Fri, Nov 8, 10:13 AM
F14020829: D7424.diff
Wed, Nov 6, 3:00 AM
F14020419: D7424.diff
Wed, Nov 6, 12:32 AM
F14005304: D7424.diff
Sun, Oct 27, 10:58 AM
F13995692: D7424.id16717.diff
Wed, Oct 23, 2:49 PM
F13979855: D7424.diff
Sat, Oct 19, 6:55 AM
F13957607: D7424.id.diff
Mon, Oct 14, 10:15 AM
Unknown Object (File)
Sat, Oct 12, 7:28 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP9a2e45ef12ea: Serve Git reads over SSH
Summary

Like D7423, but for SSH.

Test Plan

Ran git clone ssh://..., got a clone.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

so this closes stdin?

src/infrastructure/ssh/PhabricatorSSHWorkflow.php
71

Yeah -- by default, write() closes the subprocess's stdin, unless the second parameter ("$keep_pipe") is set to true. At some point, it would probably be cleaner to replace this with $exec_channel->closeWriteChannel() or something, but that doesn't exist yet.