Serve Git reads over HTTP
ClosedPublic
Actions

Authored by epriestley on Oct 26 2013, 7:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 13, 3:47 PM

	Unknown Object (File)
	Thu, Sep 12, 10:28 PM

	Unknown Object (File)
	Thu, Sep 12, 10:28 PM

	Unknown Object (File)
	Thu, Sep 12, 10:27 PM

	Unknown Object (File)
	Thu, Sep 12, 10:27 PM

	Unknown Object (File)
	Mon, Sep 9, 3:44 PM

	Unknown Object (File)
	Mon, Aug 26, 1:41 PM

	Unknown Object (File)
	Mon, Aug 26, 10:00 AM

View All Files

Subscribers

aran

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP7d9dfb561dd5: Serve Git reads over HTTP

Summary

Mostly ripped from D7391. No writes yet.

Test Plan

Ran git clone against a local over HTTP, got a clone.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Assuming this is only supposed to work for public repositories at the moment (setting the view policy to anything else results in authentication failure), then this looks reasonably good.

src/applications/diffusion/controller/DiffusionController.php
415	git-http-backend is often not in PATH; instead it sits under /usr/libexec/git or /usr/lib/git. At some point we'll need a setup check to detect if git-http-backend is not available and warn the user that they might need to set `environment.append-paths` correctly.