Page MenuHomePhabricator

Use status header stuff for "Edit Repository"
ClosedPublic

Authored by epriestley on Oct 25 2013, 11:29 PM.
Tags
None
Referenced Files
F13984318: D7411.id16698.diff
Sun, Oct 20, 12:31 PM
F13975247: D7411.id16735.diff
Fri, Oct 18, 9:21 AM
Unknown Object (File)
Fri, Oct 11, 3:15 PM
Unknown Object (File)
Oct 8 2024, 3:12 PM
Unknown Object (File)
Oct 7 2024, 12:51 PM
Unknown Object (File)
Oct 7 2024, 12:51 PM
Unknown Object (File)
Oct 7 2024, 12:51 PM
Unknown Object (File)
Oct 7 2024, 12:40 PM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP7c23960de89e: Use status header stuff for "Edit Repository"
Summary

Ref T2231. Use status info element instead of tags.

Test Plan

{F75092}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This feels a bit complicated (at least it is visually), is it just to reduce choices at the startup vs a single uber edit panel?

Yeah, it's an effort to get away from the uber edit panel which was a giant impossible mess. An earlier version of this made each section its own box, but I think they got merged at some point. I might try breaking them out again, I think it looked a bit less busy with full headers for each section rather than a series of property lists.

Can they be grouped maybe 'Basic Properties' and 'Advanced Properties'? As in, will basic settings satisfy 90% of people.

This is basically the "Advanced" view. The "Basic" view is the stepped form we walk you through to get here, and theoretically you never need to look at this again. In practice, most repositories need to configure at least some of this stuff so I think we can't really shove it under the rug too much.