Page MenuHomePhabricator
Differential D7377

Provide ConfigurationManager to LintEngine in Arcanist
ClosedPublic
Actions

Authored by epriestley on Oct 21 2013, 10:27 PM.
Tags
None
Referenced Files
F13285643: D7377.id16600.diff
Tue, Jun 4, 12:31 AM
F13284874: D7377.diff
Mon, Jun 3, 9:59 AM
F13279713: D7377.id16602.diff
Sat, Jun 1, 11:05 PM
F13279712: D7377.id16600.diff
Sat, Jun 1, 11:05 PM
F13279711: D7377.diff
Sat, Jun 1, 11:05 PM
F13246726: D7377.id16602.diff
Thu, May 23, 1:25 PM
F13215359: D7377.diff
Fri, May 17, 4:50 PM
F13209727: D7377.id16602.diff
Fri, May 17, 1:49 AM
View All Files
Subscribers
aran
csilvers

Details

Reviewers
btrahan
Commits
rARCddbc14ade196: Provide ConfigurationManager to LintEngine in Arcanist
Summary

Unbreaks ArcanistSingleLintEngine / ArcanistScriptAndRegexLinter from recent config churn.

Test Plan

arc lint --engine ArcanistSingleLintEngine --rev HEAD^

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

csilvers added a comment.Oct 21 2013, 10:33 PM

Looks good to me!, fwiw. Any commit that gets rid of a todo is good by my book (whether or not it actually fixes the thing the todo was about...)

btrahan accepted this revision.Oct 21 2013, 11:55 PM

Just revisited the configuration manager on another diff. <3 it

src/lint/engine/ArcanistLintEngine.php
73

this thing is cool.

epriestley closed this revision.Oct 21 2013, 11:58 PM

Closed by commit rARCddbc14ade196 (authored by @epriestley).

Revision Contents
Changeset List

Diff 16602

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ArcanistSingleLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility