Page MenuHomePhabricator

Provide ConfigurationManager to LintEngine in Arcanist
ClosedPublic

Authored by epriestley on Oct 21 2013, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 10:09 PM
Unknown Object (File)
Tue, Dec 10, 2:38 PM
Unknown Object (File)
Mon, Dec 9, 4:20 AM
Unknown Object (File)
Mon, Dec 9, 4:20 AM
Unknown Object (File)
Mon, Dec 9, 4:20 AM
Unknown Object (File)
Sun, Dec 8, 11:07 PM
Unknown Object (File)
Wed, Dec 4, 9:30 AM
Unknown Object (File)
Wed, Dec 4, 9:30 AM
Subscribers

Details

Summary

Unbreaks ArcanistSingleLintEngine / ArcanistScriptAndRegexLinter from recent config churn.

Test Plan

arc lint --engine ArcanistSingleLintEngine --rev HEAD^

Diff Detail

Branch
singlelint
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Looks good to me!, fwiw. Any commit that gets rid of a todo is good by my book (whether or not it actually fixes the thing the todo was about...)

Just revisited the configuration manager on another diff. <3 it

src/lint/engine/ArcanistLintEngine.php
73

this thing is cool.