Page MenuHomePhabricator
Differential D7377

Provide ConfigurationManager to LintEngine in Arcanist
ClosedPublic
Actions

Authored by epriestley on Oct 21 2013, 10:27 PM.
Tags
None
Referenced Files
F15341324: D7377.id16600.diff
Sun, Mar 9, 7:41 PM
Unknown Object (File)
Fri, Feb 28, 12:05 PM
Unknown Object (File)
Thu, Feb 27, 3:22 AM
Unknown Object (File)
Thu, Feb 27, 3:22 AM
Unknown Object (File)
Thu, Feb 27, 3:21 AM
Unknown Object (File)
Sat, Feb 22, 7:43 PM
Unknown Object (File)
Sun, Feb 9, 10:22 AM
Unknown Object (File)
Sun, Feb 9, 10:22 AM
View All Files
Subscribers
aran
csilvers

Details

Reviewers
btrahan
Commits
rARCddbc14ade196: Provide ConfigurationManager to LintEngine in Arcanist
Summary

Unbreaks ArcanistSingleLintEngine / ArcanistScriptAndRegexLinter from recent config churn.

Test Plan

arc lint --engine ArcanistSingleLintEngine --rev HEAD^

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

csilvers added a comment.Oct 21 2013, 10:33 PM

Looks good to me!, fwiw. Any commit that gets rid of a todo is good by my book (whether or not it actually fixes the thing the todo was about...)

btrahan accepted this revision.Oct 21 2013, 11:55 PM

Just revisited the configuration manager on another diff. <3 it

src/lint/engine/ArcanistLintEngine.php
73

this thing is cool.

epriestley closed this revision.Oct 21 2013, 11:58 PM

Closed by commit rARCddbc14ade196 (authored by @epriestley).

Revision Contents
Changeset List

Diff 16602

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ArcanistSingleLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility