Page MenuHomePhabricator
Differential D7377

Provide ConfigurationManager to LintEngine in Arcanist
ClosedPublic
Actions

Authored by epriestley on Oct 21 2013, 10:27 PM.
Tags
None
Referenced Files
F13324799: D7377.diff
Sat, Jun 15, 1:00 AM
F13311973: D7377.diff
Tue, Jun 11, 5:58 AM
F13300690: D7377.diff
Fri, Jun 7, 9:27 AM
F13297348: D7377.id.diff
Fri, Jun 7, 4:04 AM
F13285643: D7377.id16600.diff
Tue, Jun 4, 12:31 AM
F13284874: D7377.diff
Mon, Jun 3, 9:59 AM
F13279713: D7377.id16602.diff
Sat, Jun 1, 11:05 PM
F13279712: D7377.id16600.diff
Sat, Jun 1, 11:05 PM
View All Files
Subscribers
aran
csilvers

Details

Reviewers
btrahan
Commits
rARCddbc14ade196: Provide ConfigurationManager to LintEngine in Arcanist
Summary

Unbreaks ArcanistSingleLintEngine / ArcanistScriptAndRegexLinter from recent config churn.

Test Plan

arc lint --engine ArcanistSingleLintEngine --rev HEAD^

Diff Detail

Branch
singlelint
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

csilvers added a comment.Oct 21 2013, 10:33 PM

Looks good to me!, fwiw. Any commit that gets rid of a todo is good by my book (whether or not it actually fixes the thing the todo was about...)

btrahan accepted this revision.Oct 21 2013, 11:55 PM

Just revisited the configuration manager on another diff. <3 it

src/lint/engine/ArcanistLintEngine.php
73

this thing is cool.

epriestley closed this revision.Oct 21 2013, 11:58 PM

Closed by commit rARCddbc14ade196 (authored by @epriestley).

Revision Contents
Changeset List

Diff 16600

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ArcanistSingleLintEngine.php

Loading...
View Options

src/lint/linter/ArcanistScriptAndRegexLinter.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility