Paths

Table of Contentst

Clean up some ordering and strata edge cases in Phrequent
ClosedPublic
Actions

Authored by epriestley on Oct 18 2013, 9:43 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 2, 4:09 AM

	Unknown Object (File)
	Tue, Dec 31, 9:12 PM

	Unknown Object (File)
	Mon, Dec 30, 4:25 AM

	Unknown Object (File)
	Sun, Dec 29, 8:20 PM

	Unknown Object (File)
	Mon, Dec 9, 6:39 AM

	Unknown Object (File)
	Mon, Dec 9, 4:14 AM

	Unknown Object (File)
	Mon, Dec 9, 4:14 AM

	Unknown Object (File)
	Mon, Dec 9, 4:14 AM

View All Files

Subscribers

aran

skyronic

Details

Reviewers

btrahan

Maniphest Tasks

T3569: Make Phrequent somewhat usable

Commits

Restricted Diffusion Commit
rPf5c7dd68d217: Clean up some ordering and strata edge cases in Phrequent

Summary

Ref T3569. Two issues:

Since sort() is not stable, instantaneous events (ending on the same second they start) would sometime sort wrong and produce the wrong results. Guarantee they sort correctly.
Because events can end at any time, there are some additional special cases the algorithm didn't handle properly. Draw a bunch of ASCII art diagrams so these cases work properly.

Test Plan

No more fatal when tracking an object for the first time.
Unit tests.

Diff Detail

Branch

pstrata

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

"Thank goodness for the ASCII art" the reviewer thought to himself. :D

Closed by commit rPf5c7dd68d217 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phrequent/

storage/

PhrequentTimeBlock.php

129 lines

__tests__/

PhrequentTimeBlockTestCase.php

100 lines

Diff 16553

View Options

src/applications/phrequent/storage/PhrequentTimeBlock.php

View Options

src/applications/phrequent/storage/tests/PhrequentTimeBlockTestCase.php

Clean up some ordering and strata edge cases in PhrequentClosedPublicActions