Paths

Table of Contentst

Fix lightbox downloads for embeded images and a warning
ClosedPublic
Actions

Authored by epriestley on Oct 17 2013, 6:16 PM.

Tags

None

Referenced Files

	F15341211: D7341.diff
	Sun, Mar 9, 7:05 PM

	Unknown Object (File)
	Fri, Feb 14, 4:27 AM

	Unknown Object (File)
	Tue, Feb 11, 11:04 AM

	Unknown Object (File)
	Feb 7 2025, 9:41 AM

	Unknown Object (File)
	Feb 7 2025, 9:41 AM

	Unknown Object (File)
	Feb 7 2025, 8:36 AM

	Unknown Object (File)
	Feb 7 2025, 8:01 AM

	Unknown Object (File)
	Feb 4 2025, 4:13 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
dctrwatson

Commits

Restricted Diffusion Commit
rP32dca4b553f8: Fix lightbox downloads for embeded images and a warning

Summary

I refactored this recently and accidentally dropped the download URI.

Also fix a warning with, e.g., files named README.

Test Plan

Clicked a thumb, clicked "Download", got a file.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Oct 17 2013, 6:17 PM

Closed by commit rP32dca4b553f8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

2 lines

files/

remarkup/

PhabricatorRemarkupRuleEmbedFile.php

1 line

Diff 16534

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php