Paths

Table of Contentst

Fix lightbox downloads for embeded images and a warning
ClosedPublic
Actions

Authored by epriestley on Oct 17 2013, 6:16 PM.

Tags

None

Referenced Files

	F14035594: D7341.id16534.diff
	Sun, Nov 10, 6:37 AM

	F14011964: D7341.diff
	Fri, Nov 1, 6:19 AM

	F14009746: D7341.diff
	Wed, Oct 30, 11:48 PM

	F14006257: D7341.diff
	Mon, Oct 28, 4:15 AM

	F14003746: D7341.id16533.diff
	Sat, Oct 26, 10:17 AM

	F14002730: D7341.diff
	Fri, Oct 25, 9:45 PM

	F14001275: D7341.id16533.diff
	Fri, Oct 25, 5:56 AM

	F13977771: D7341.id16534.diff
	Fri, Oct 18, 7:58 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
dctrwatson

Commits

Restricted Diffusion Commit
rP32dca4b553f8: Fix lightbox downloads for embeded images and a warning

Summary

I refactored this recently and accidentally dropped the download URI.

Also fix a warning with, e.g., files named README.

Test Plan

Clicked a thumb, clicked "Download", got a file.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Oct 17 2013, 6:17 PM

Closed by commit rP32dca4b553f8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

2 lines

files/

remarkup/

PhabricatorRemarkupRuleEmbedFile.php

1 line

Diff 16534

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php