Paths

Table of Contentst

Fix lightbox downloads for embeded images and a warning
ClosedPublic
Actions

Authored by epriestley on Oct 17 2013, 6:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Sep 2, 5:45 AM

	Unknown Object (File)
	Mon, Sep 2, 3:21 AM

	Unknown Object (File)
	Tue, Aug 27, 2:41 AM

	Unknown Object (File)
	Fri, Aug 23, 6:30 PM

	Unknown Object (File)
	Aug 18 2024, 4:20 AM

	Unknown Object (File)
	Aug 17 2024, 5:05 AM

	Unknown Object (File)
	Aug 6 2024, 6:47 AM

	Unknown Object (File)
	Jul 29 2024, 6:28 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
dctrwatson

Commits

Restricted Diffusion Commit
rP32dca4b553f8: Fix lightbox downloads for embeded images and a warning

Summary

I refactored this recently and accidentally dropped the download URI.

Also fix a warning with, e.g., files named README.

Test Plan

Clicked a thumb, clicked "Download", got a file.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad accepted this revision.Oct 17 2013, 6:17 PM

Closed by commit rP32dca4b553f8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

view/

DifferentialChangesetDetailView.php

2 lines

files/

remarkup/

PhabricatorRemarkupRuleEmbedFile.php

1 line

Diff 16534

View Options

src/applications/differential/view/DifferentialChangesetDetailView.php