Page MenuHomePhabricator
Differential D7331

Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Authored by epriestley on Oct 16 2013, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:07 AM
Unknown Object (File)
Sat, Jan 18, 9:19 AM
Unknown Object (File)
Fri, Jan 17, 10:23 PM
Unknown Object (File)
Fri, Jan 17, 2:29 AM
Unknown Object (File)
Sat, Jan 11, 11:02 PM
Unknown Object (File)
Mon, Jan 6, 6:33 AM
Unknown Object (File)
Mon, Jan 6, 6:13 AM
Unknown Object (File)
Sat, Jan 4, 2:27 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T3274: Add Text Macro Generator to Phabricator / Remarkup
T3591: Render PlantUML syntax as macro in remarkup areas.
T3964: graphviz plugin for editor
Commits
rPHUd422741443dd: Expand Remarkup interpreter block capabilities a little bit
Summary

Ref T3274. Ref T3591. Ref T3964. Allows interpreters to access the engine so they can check for text mode, grab the viewer/config, etc.

Also, make the unit tests not depend on trailing whitespace to pass.

Test Plan

See next revision.

Diff Detail

Branch
iblocks
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/markup/engine/__tests__/remarkup/interpreter-test.txt:28TXT3Line Too Long
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Oct 16 2013, 10:42 PM

"I am okay with the lint problem."

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php
11

typehint maybs

epriestley closed this revision.Oct 17 2013, 2:08 AM

Closed by commit rPHUd422741443dd (authored by @epriestley).

Revision Contents
Changeset List

Diff 16509

View Options

src/markup/engine/__tests__/remarkup/interpreter-test.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Loading...
Phabricator · Built by Phacility