Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Authored by epriestley on Oct 16 2013, 7:09 PM.

Details

Reviewers

Maniphest Tasks

T3274: Add Text Macro Generator to Phabricator / Remarkup
T3591: Render PlantUML syntax as macro in remarkup areas.
T3964: graphviz plugin for editor

Commits

rPHUd422741443dd: Expand Remarkup interpreter block capabilities a little bit

Summary

Ref T3274. Ref T3591. Ref T3964. Allows interpreters to access the engine so they can check for text mode, grab the viewer/config, etc.

Also, make the unit tests not depend on trailing whitespace to pass.

Test Plan

See next revision.

Diff Detail

Branch

iblocks

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/markup/engine/__tests__/remarkup/interpreter-test.txt:28	TXT3	Line Too Long

Unit

Tests Passed

Event Timeline

"I am okay with the lint problem."

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php
11	typehint maybs

Closed by commit rPHUd422741443dd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

interpreter-test.txt

32 lines

remarkup/

blockrule/

PhutilRemarkupBlockInterpreter.php

24 lines

PhutilRemarkupEngineRemarkupInterpreterRule.php

13 lines

PhutilRemarkupEngineRemarkupTestInterpreterRule.php

2 lines

Diff 16509

View Options

src/markup/engine/tests/remarkup/interpreter-test.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Expand Remarkup interpreter block capabilities a little bitClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16509

src/markup/engine/__tests__/remarkup/interpreter-test.txt

src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockInterpreter.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupInterpreterRule.php

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupTestInterpreterRule.php

Expand Remarkup interpreter block capabilities a little bit
ClosedPublic
Actions

Revision Contents
Changeset List

src/markup/engine/tests/remarkup/interpreter-test.txt