Render public content as "Public" in headers, not "Public (No Login Required)"
ClosedPublic
Actions

Authored by epriestley on Oct 14 2013, 8:04 PM.

Tags

None

Referenced Files

	F13287001: D7310.diff
	Tue, Jun 4, 8:06 AM

	F13277838: D7310.diff
	Fri, May 31, 2:16 PM

	F13259808: D7310.diff
	Sun, May 26, 11:07 PM

	F13242645: D7310.diff
	Thu, May 23, 2:58 AM

	F13240034: D7310.id16468.diff
	Wed, May 22, 9:34 AM

	F13220867: D7310.diff
	Sun, May 19, 2:00 AM

	F13202164: D7310.diff
	Tue, May 14, 10:20 PM

	F13198076: D7310.id16468.diff
	Mon, May 13, 3:24 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad

Maniphest Tasks

T603: Support permissions/policies in all Phabricator applications

Commits

Restricted Diffusion Commit
rP502c6f2d4816: Render public content as "Public" in headers, not "Public (No Login Required)"

Summary

Ref T603. Although I think the parenthetical is valuable when setting policies to make sure no one accidentally opens content up, it's super annoying in headers.

This makes headers say "Public". Everything else still says "Public (No Login Required)".

Test Plan

{F69469}

Diff Detail

Branch

pshortname

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

I often wonder if 'All Users' is clear enough, as I sometimes feel that means Public. 'Registered Users' or 'Logged In Users' or something similar? I don't feel strongly here, just tossing it out there.