Page MenuHomePhabricator

Render public content as "Public" in headers, not "Public (No Login Required)"
ClosedPublic

Authored by epriestley on Oct 14 2013, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:10 PM
Unknown Object (File)
Fri, Apr 19, 3:25 AM
Unknown Object (File)
Fri, Apr 19, 3:25 AM
Unknown Object (File)
Fri, Apr 19, 3:25 AM
Unknown Object (File)
Sun, Apr 14, 3:45 AM
Unknown Object (File)
Thu, Apr 11, 8:00 AM
Unknown Object (File)
Thu, Apr 11, 4:36 AM
Unknown Object (File)
Sat, Apr 6, 5:13 PM
Subscribers

Details

Summary

Ref T603. Although I think the parenthetical is valuable when setting policies to make sure no one accidentally opens content up, it's super annoying in headers.

This makes headers say "Public". Everything else still says "Public (No Login Required)".

Test Plan

{F69469}

Diff Detail

Branch
pshortname
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

I often wonder if 'All Users' is clear enough, as I sometimes feel that means Public. 'Registered Users' or 'Logged In Users' or something similar? I don't feel strongly here, just tossing it out there.