Page MenuHomePhabricator

Render public content as "Public" in headers, not "Public (No Login Required)"
ClosedPublic

Authored by epriestley on Oct 14 2013, 8:04 PM.
Tags
None
Referenced Files
F17377097: D7310.diff
Sat, Jun 28, 6:19 PM
Unknown Object (File)
Sat, Jun 7, 3:01 AM
Unknown Object (File)
May 29 2025, 6:53 PM
Unknown Object (File)
May 28 2025, 9:16 AM
Unknown Object (File)
May 27 2025, 7:26 PM
Unknown Object (File)
Apr 28 2025, 6:59 PM
Unknown Object (File)
Apr 27 2025, 9:21 AM
Unknown Object (File)
Apr 26 2025, 6:13 PM
Subscribers

Details

Summary

Ref T603. Although I think the parenthetical is valuable when setting policies to make sure no one accidentally opens content up, it's super annoying in headers.

This makes headers say "Public". Everything else still says "Public (No Login Required)".

Test Plan

{F69469}

Diff Detail

Branch
pshortname
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

I often wonder if 'All Users' is clear enough, as I sometimes feel that means Public. 'Registered Users' or 'Logged In Users' or something similar? I don't feel strongly here, just tossing it out there.