Page MenuHomePhabricator

Fix issue reported from github
ClosedPublic

Authored by btrahan on Oct 10 2013, 10:05 PM.
Tags
None
Referenced Files
F13344050: D7284.diff
Fri, Jun 21, 6:41 AM
F13331331: D7284.diff
Mon, Jun 17, 6:28 AM
F13318626: D7284.diff
Thu, Jun 13, 11:19 AM
F13306297: D7284.diff
Sun, Jun 9, 7:46 AM
F13305080: D7284.diff
Sat, Jun 8, 4:47 PM
F13292909: D7284.diff
Wed, Jun 5, 5:31 AM
F13280257: D7284.id16399.diff
Sun, Jun 2, 4:07 AM
F13279204: D7284.diff
Sat, Jun 1, 12:32 PM

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdb71bf6128c8: Fix issue reported from github
Summary

we filter the $actors above such that its possible to have no $actor anymore (if $actor is not a deliverable email address). ergo, make sure we have actor before we start calling methods.

Fixes github issue 403

Test Plan

logic on this one - not 100% sure how to easily reproduce

Diff Detail

Branch
github-403
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Ah, thanks. I took a peek at this and imagined writing a similar patch, but then forgot about it instead. Pretty sure this is the way to go, though.