Page MenuHomePhabricator

Fix issue reported from github
ClosedPublic

Authored by btrahan on Oct 10 2013, 10:05 PM.
Tags
None
Referenced Files
F19506516: D7284.id16399.diff
Fri, Jan 9, 4:47 PM
F19506463: D7284.id16398.diff
Fri, Jan 9, 4:46 PM
F19072693: D7284.id16399.diff
Nov 30 2025, 11:19 PM
F19050613: D7284.id.diff
Nov 27 2025, 8:23 PM
F19014617: D7284.diff
Nov 22 2025, 8:37 PM
F18814297: D7284.id.diff
Oct 20 2025, 10:56 PM
F18803826: D7284.diff
Oct 18 2025, 4:12 AM
F18746801: D7284.id16399.diff
Oct 3 2025, 1:30 PM

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPdb71bf6128c8: Fix issue reported from github
Summary

we filter the $actors above such that its possible to have no $actor anymore (if $actor is not a deliverable email address). ergo, make sure we have actor before we start calling methods.

Fixes github issue 403

Test Plan

logic on this one - not 100% sure how to easily reproduce

Diff Detail

Branch
github-403
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Ah, thanks. I took a peek at this and imagined writing a similar patch, but then forgot about it instead. Pretty sure this is the way to go, though.