Changeset View
Changeset View
Standalone View
Standalone View
webroot/rsrc/js/application/projects/WorkboardBoard.js
Show First 20 Lines • Show All 473 Lines • ▼ Show 20 Lines | _onmovecard: function(list, item, after_node, src_list) { | ||||
var visible_phids = []; | var visible_phids = []; | ||||
var column = this.getColumn(dst_phid); | var column = this.getColumn(dst_phid); | ||||
for (var object_phid in column.getCards()) { | for (var object_phid in column.getCards()) { | ||||
visible_phids.push(object_phid); | visible_phids.push(object_phid); | ||||
} | } | ||||
data.visiblePHIDs = visible_phids.join(','); | data.visiblePHIDs = visible_phids.join(','); | ||||
// If the user cancels the workflow (for example, by hitting an MFA | |||||
// prompt that they click "Cancel" on), put the card back where it was | |||||
// and reset the UI state. | |||||
var on_revert = JX.bind( | |||||
this, | |||||
this._revertCard, | |||||
list, | |||||
item, | |||||
src_phid, | |||||
dst_phid); | |||||
var onupdate = JX.bind( | var onupdate = JX.bind( | ||||
this, | this, | ||||
this._oncardupdate, | this._oncardupdate, | ||||
list, | list, | ||||
src_phid, | src_phid, | ||||
dst_phid, | dst_phid, | ||||
data.afterPHID); | data.afterPHID); | ||||
new JX.Workflow(this.getController().getMoveURI(), data) | new JX.Workflow(this.getController().getMoveURI(), data) | ||||
.setHandler(onupdate) | .setHandler(onupdate) | ||||
.setCloseHandler(on_revert) | |||||
.start(); | .start(); | ||||
}, | }, | ||||
_revertCard: function(list, item, src_phid, dst_phid) { | |||||
JX.DOM.alterClass(item, 'drag-sending', false); | |||||
var src_column = this.getColumn(src_phid); | |||||
var dst_column = this.getColumn(dst_phid); | |||||
src_column.markForRedraw(); | |||||
dst_column.markForRedraw(); | |||||
this._redrawColumns(); | |||||
list.unlock(); | |||||
amckinley: Should this have a corresponding `lock()` somewhere? | |||||
Done Inline ActionsThe paired lock() happens when you first pick up the card. We unlock() on success (below, in _oncardupdate()) already, this just adds an unlock when we complete the drag but have failed. epriestley: The paired `lock()` happens when you first pick up the card.
We `unlock()` on success (below… | |||||
}, | |||||
_oncardupdate: function(list, src_phid, dst_phid, after_phid, response) { | _oncardupdate: function(list, src_phid, dst_phid, after_phid, response) { | ||||
var src_column = this.getColumn(src_phid); | var src_column = this.getColumn(src_phid); | ||||
var dst_column = this.getColumn(dst_phid); | var dst_column = this.getColumn(dst_phid); | ||||
var card = src_column.removeCard(response.objectPHID); | var card = src_column.removeCard(response.objectPHID); | ||||
dst_column.addCard(card, after_phid); | dst_column.addCard(card, after_phid); | ||||
src_column.markForRedraw(); | src_column.markForRedraw(); | ||||
▲ Show 20 Lines • Show All 105 Lines • Show Last 20 Lines |
Should this have a corresponding lock() somewhere?