Differential D14485 Diff 35049 src/applications/differential/controller/DifferentialChangesetViewController.php

Changeset View

Standalone View

Show First 20 Lines • Show All 380 Lines • ▼ Show 20 Lines	private function buildLintInlineComments($changeset) {

$template = id(new DifferentialInlineComment())		$template = id(new DifferentialInlineComment())
->setChangesetID($changeset->getID())		->setChangesetID($changeset->getID())
->setIsNewFile(1)		->setIsNewFile(1)
->setLineLength(0);		->setLineLength(0);

$inlines = array();		$inlines = array();
foreach ($messages as $message) {		foreach ($messages as $message) {
$description = $message->getProperty('description');		$description = $message->getProperty('description');
$description = '%%%'.$description.'%%%';

		epriestleyUnsubmitted Not Done Inline Actions I will boldly claim that this line can be completely removed without disastrous effect. epriestley: I will boldly claim that this line can be //completely// removed without disastrous effect.
$inlines[] = id(clone $template)		$inlines[] = id(clone $template)
->setSyntheticAuthor(pht('Lint: %s', $message->getName()))		->setSyntheticAuthor(pht('Lint: %s', $message->getName()))
->setLineNumber($message->getLine())		->setLineNumber($message->getLine())
->setContent($description);		->setContent($description);
}		}

return $inlines;		return $inlines;
}		}
Show All 25 Lines