Page MenuHomePhabricator

arc land incorrectly reports I used `--onto`
Closed, InvalidPublic

Description

Not the highest priority bug in the world, but I ran this:

% arc land
Landing current branch 'profile-model-test'.
 TARGET  Landing onto "web-perf", selected by the --onto flag.
 REMOTE  Using remote "origin", selected by following tracking branches upstream to the closest remote.

It said: "selected by the --onto flag", but I did not actually use the --onto flag. (In reality, it landed onto web-perf because that was the upstream; profile-model-test was a tracking branch.)

Event Timeline

csilvers raised the priority of this task from to Needs Triage.
csilvers updated the task description. (Show Details)
csilvers changed the edit policy from "All Users" to "Custom Policy".
csilvers added projects: Bug Report, Arcanist.
csilvers added a subscriber: csilvers.

I can't reproduce this:

$ git checkout test
Already on 'test'
Your branch is up-to-date with 'origin/test'.

$ git checkout --track -b featuretest1
Branch featuretest1 set up to track local branch test.
Switched to a new branch 'featuretest1'

$ git commit --allow-empty -m test
[featuretest1 336516c] test

$ arc land
Landing current branch 'featuretest1'.
 TARGET  Landing onto "test", selected by following tracking branches upstream to the closest remote.
 REMOTE  Using remote "origin", selected by following tracking branches upstream to the closest remote.

The code which generates this message also seems unambiguous at HEAD, and reads only from the arguments:

$onto = $this->getArgument('onto');
if ($onto !== null) {
  $this->writeInfo(
    pht('TARGET'),
    pht(
      'Landing onto "%s", selected by the --onto flag.',
      $onto));
  return $onto;
}

Is it possible you have a shell alias or something?

I don't have a shell alias, but I do have a wrapper script around arc. Doh! I totally forgot about that. Sorry for the false alarm.

(I'm a bit confused by bugs being tasks now, but I'll see if I can close this.)

csilvers claimed this task.

I inducted you into Community so you should have sweeping editorial powers once again.

w00t w00t, I got something out of this bug report after all!