Page MenuHomePhabricator

Improve Arcanist FileName Linter to highlight the part the path failing
Closed, InvalidPublic

Description

Basically I get :

linter.png (438×798 px, 62 KB)

Note that :

  • first the new lint for xxx is not separated from previous block so it makes prety hard to detect it (i didn't) but
  • the FilenameLinter did print that it accept only letter, number, period but Cahier_des_charges....docx wasn't accepted since the C : so a lowercase letter in the description would be more appropriate.
  • contrary to other linters that clearly highlight the part that falls, filename did not !

Event Timeline

epriestley claimed this task.
epriestley added a subscriber: epriestley.
$ arc lint
>>> Lint for $ $ README $ $:


   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.

Note filename in output, on line 2:

>>> Lint for $ $ README $ $:

@tycho.tatitscheff can you give us some better insight of if you're aware of our Bug Reporting/Feature Request guidelines, and if you are why they are not followed? Do you just feel like they don't apply to you?

tycho.tatitscheff renamed this task from Improve Arcanist FileName Linter to print the path failing to Improve Arcanist FileName Linter to highlight the part the path failing .Nov 4 2015, 5:25 PM
tycho.tatitscheff updated the task description. (Show Details)

I can't reproduce the capital letter issue.

epriestley@orbital ~/dev/arcanist $ git show --raw
commit 88a21561e618e59709cc8b6a5e6aace37e67d474
Author: epriestley <git@epriestley.com>
Date:   Wed Nov 4 09:31:15 2015 -0800

    WIP

:000000 100644 0000000... 135f5fd... A  $ bad $
:000000 100644 0000000... f2e4113... A  Cahier_des_charges_fonctionnelles.docx

Note that ONLY the filename with "$" in it is caught:

epriestley@orbital ~/dev/arcanist $ arc lint
>>> Lint for $ bad $:


   Error  (NAME1) Bad Filename
    Name files using only letters, numbers, period, hyphen and underscore.
epriestley@orbital ~/dev/arcanist $

I didn't indended to submit as it was.
The description I edited just after was not send through my mobile tethered connection. I just have sended it now !

In T9710#143121, @chad wrote:

@tycho.tatitscheff Do you just feel like they don't apply to you?

Don't think so and look at my other bug report (for instance T8982) -> I often spend hours writing them so it can be useful.
Making such a generality is a little bit harsh but nevermind, it was my fault.

After writing a lot of answer in our ponder instance, I take the habit to write them in two times (write and edit), in order to get the remarkup preview. I know that is bad and have now sence for maniphest but I wasn't really wanting to send this empty task.

Not sure what happened.
It seems logical that it also matches the caps since the @i in the regex. So it must be something else.
I would see tomorrow. Maybe it was just Cahier_des_charges fonctionelles (somehere no underscore but an space). But in my shell, since all was underlined i'm not sure I would have distinguished it but I was pretty sure I have look there wasn't space instead of underscore.

If it was , sorry for this invalid report.
However underlining the failure would still have been a lot more clear.

Making such a generality is a little bit harsh

I don't believe it's a generality. 20/36 tasks authored by you in the upstream have been closed as duplicate, wontfix, or invalid. That's a greater than 50% hit rate on non-useful tickets. 1/8 diffs have been accepted and 1/1 of those had problems afterwards. I don't know how to look at this other than by what the data tells me. "Free Support" costs Phacilty money and Phabricator features. We're not staffed and flush enough to maintain this level of community support, which is why we rely heavily on people following the documentation on filing requests for help.