Give Harbormaster build steps a "View" page
ClosedPublic
Actions

Authored by epriestley on Oct 24 2015, 7:26 PM.

Details

Reviewers

chad

Maniphest Tasks

T9519: Design the Drydock Blueprint selection mechanism

Commits

Restricted Diffusion Commit
rP3f193cb9e06c: Give Harbormaster build steps a "View" page

Summary

Fixes T9519. Right now, build steps go straight from the build to the edit screen.

This means that there's no way to see their edit history or review details without edit permission. In particular, this makes it a bit harder to catch the Drydock Blueprint authorization warnings from T9519.

Add a standard view screen.
Add a little warning callout to blueprint authorizations.

This also does a bit of a touchup on the weird dropshadow element from T9586. Maybe not totally design-approved now but it's less ugly, at least.

Test Plan

Screen Shot 2015-10-24 at 12.14.42 PM.png (420×553 px, 47 KB)

Screen Shot 2015-10-24 at 12.14.34 PM.png (220×696 px, 35 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34588.Oct 24 2015, 7:26 PM

epriestley retitled this revision from to Give Harbormaster build steps a "View" page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9519: Design the Drydock Blueprint selection mechanism.

Herald edited edge metadata. · View Herald TranscriptOct 24 2015, 7:26 PM

Be more consistent with the variable type for $warnings.

Herald edited edge metadata. · View Herald TranscriptOct 24 2015, 7:30 PM

We have something similar like this on connected accounts page. No border maybe?

This revision is now accepted and ready to land.Oct 24 2015, 7:42 PM

As is:

No border:

Screen Shot 2015-10-24 at 1.02.57 PM.png (414×335 px, 44 KB)

No border + no background:

Screen Shot 2015-10-24 at 1.03.03 PM.png (413×437 px, 45 KB)

Dropping only the border feels a little weird to me but dropping them both seems fine. I'll just drop them and you can touch it up eventually if you want.

Closed by commit rP3f193cb9e06c: Give Harbormaster build steps a "View" page (authored by epriestley, committed by epriestley). · Explain WhyOct 26 2015, 7:38 PM

This revision was automatically updated to reflect the committed changes.