Page MenuHomePhabricator
Create Task
Maniphest T9344

When chat entry is image macro, show only the information of the message in the image, not the macro itself
Closed, DuplicatePublic
Actions

Description

Problem: When an image macro is used in the regular chat, the result is - as expected - an image. The issue is that the chat notification widget in the header shows the actual image macro string, which doesn't look nicely integrated:

Screen Shot 2015-09-04 at 07.19.11.png (194×802 px, 40 KB)

Possible solution: Wouldn't it make more sense to concatenate the strings in this case of parameters 'above' and 'below' and show these instead? So the information is transported to the notification widget, just presented in a way that fits the context. E.g. above = THIS IS, below = AWESOME, the message in the notification will be THIS IS AWESOME.

Related Objects

Event Timeline

CaptSpot created this task.Sep 4 2015, 3:59 PM
CaptSpot assigned this task to epriestley.
CaptSpot updated the task description. (Show Details)
CaptSpot added a project: Conpherence.
CaptSpot added a subscriber: CaptSpot.
chad added a subscriber: chad.Sep 4 2015, 5:40 PM

Remarkup doesn't work like this, there is the raw and there is marked up. We don't cache/build other outputs like raw-ish.

chad closed this task as Wontfix.Sep 4 2015, 5:43 PM

T2849 has a sort of better explanation of what Remarkup is/does.

epriestley added a comment.Sep 4 2015, 5:52 PM

Remarkup does have multiple rendering modes. There are currently three: email-text (used for text email bodies), email-html (used for html email bodies) and html (used elsewhere).

T3278 discusses adding a "summary" mode which might be applicable here (render some HTML, like bold/italic, but not images/embeds).

chad added a comment.Sep 4 2015, 6:06 PM

Oh! I had forgot about that task. Sounds like a good place to merge.

chad closed this task as a duplicate of T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.Sep 4 2015, 6:06 PM
chad added a comment.Sep 4 2015, 6:13 PM

Also as an aside, I prefer the raw markup in the meme case at least. I know what success_kid is, so I can actually envision the meme. Changing this markup would need to convey all the same information.

Phabricator · Built by Phacility